server.rs - move response handling into .process() #1727
Merged
+35
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
There are a few renames:
process_messages
->run_loop
.process
method and its not clear what the difference is.run
method that calls it and add_loop
send_receive_chain_loop
could also be a reasonable nameprocess
->send_receive_chain
The main point of the PR is to move sending of responses into
send_receive_chain
.To achieve this the
CloseReason
enum is introduced, currently only the existence of theCloseReason
is meaningful so there is only one variant.The existence of the
CloseReason
indicates torun_loop
whether to terminate the loop or not.CloseReason
will be extended in #1722 to have unique handling for different close reasons.